microsoft / microsoft/winget-pkgs
Pipelines should detect missing zip fields in the manifest
Nobody has claimed this yet.
- Dominant language
- No language data
- Stars
- 11.1k
- Forks
- 9.7k
- Avg merge
- 1h 32m
- Merged PRs (30d)
- 376
Description
Description of the new feature/enhancement
If the installer is zip based, pipelines should validate that InstallerType: zip is specified against the installer in the manifest. It should also validate that NestedInstallerType & NestedInstallerFiles are present in the manifest.
Context
A zip based package was merged in https://github.com/microsoft/winget-pkgs/pull/188685 which didn't contain the appropriate ZIP-based fields. The package still installed successfully as the CLI does not appear to rely on those manifest fields for zip installation. But this caused an issue when updating the package through winget-create. See https://github.com/microsoft/winget-create/issues/559
Proposed technical implementation details (optional)
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the pipeline validation entry point for installer manifests and review the zip package in PR 188685 alongside the winget-create issue 559. Done means zip-based manifests are rejected when InstallerType, NestedInstallerType, or NestedInstallerFiles is missing.
Written by the indexing model from the issue text.
Assessment
- Domain
- ci-cd
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100