microsoft / microsoft/winget-pkgs
Pipelines should notify of manifest validation warnings on a PR
Nobody has claimed this yet.
- Dominant language
- No language data
- Stars
- 11.1k
- Forks
- 9.7k
- Avg merge
- 1h 32m
- Merged PRs (30d)
- 376
Description
Description of the new feature/enhancement
When winget validate succeeds with warnings, the pipelines should ideally apply a label / add a comment notifying PR author and reviewers of the warnings.
Seen in https://github.com/microsoft/winget-pkgs/pull/167554, where Moniker (only supported in defaultLocale manifests) was put in locale manifests and pipelines didn't warn about it
The winget validate output for above PR would've been
Manifest validation succeeded with warnings.
Manifest Warning: Unknown field. [Moniker]
Proposed technical implementation details (optional)
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the validation pipeline entry point that runs winget validate, using PR 167554 as the warning example. The work is done when validation warnings such as Unknown field. [Moniker] reliably notify the PR author and reviewers through a label or comment.
Written by the indexing model from the issue text.
Assessment
- Domain
- ci-cd
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100