microsoft / microsoft/winget-pkgs

[Package Issue]: Sigil-Ebook.Sigil - new version PR failure

Open
#147,337 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dependencies Issue-Bug
Dominant language
No language data
Stars
11.1k
Forks
9.7k
Avg merge
1h 32m
Merged PRs (30d)
376

Description

Please confirm these before moving forward
  • I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
  • I have not been informed if the issue is resolved in a preview version of the winget client.
Category of the issue

Other

Brief description of your issue

Installer validation error in the Azure pipeline: #147284

It seems to be related to a dependency package (Microsoft.VCRedist.2015+.x64) and not my package itself. Short of removing the dependency, I don't see anything that I can push to my PR branch to fix it.

There's an identical Automatic validation error here: https://github.com/microsoft/winget-pkgs/pull/147206#issuecomment-2029833788

And another one where the same error was wavered last week: https://github.com/microsoft/winget-pkgs/pull/146365#issuecomment-2018115442

Why so many failures with manifests that have winget dependency package requirements in their installer yaml?

Steps to reproduce

Include the following in a package installer manifest:

Dependencies:
PackageDependencies:

  • PackageIdentifier: Microsoft.VCRedist.2015+.x64
Actual behavior

2024-04-01 18:03:47.191 [FAIL] D:\a_work\1\s\external\pkg\src\AppInstallerRepositoryCore\RepositorySource.cpp(757)\WindowsPackageManager.dll!00007FFA4CC1C11F: (caller: 00007FFA4C9A8D6F) LogHr(1) tid(1cf8) 8A15005E Msg:[D:\a_work\1\s\external\pkg\src\AppInstallerRepositoryCore\Rest\Schema\HttpClientHelper.cpp(30)\WindowsPackageManager.dll!00007FFA4CB22B08: (caller: 00007FFA4CBCBC20) Exception(1) tid(1cf8) 8A15005E ]
2024-04-01 18:03:47.191 [REPO] Failed to open available source: msstore
2024-04-01 18:03:54.851 [FAIL] D:\a_work\1\s\external\pkg\src\AppInstallerRepositoryCore\RepositorySource.cpp(757)\WindowsPackageManager.dll!00007FFA31D3C11F: (caller: 00007FFA31AC8D6F) LogHr(1) tid(67c) 8A15005E Msg:[D:\a_work\1\s\external\pkg\src\AppInstallerRepositoryCore\Rest\Schema\HttpClientHelper.cpp(30)\WindowsPackageManager.dll!00007FFA31C42B08: (caller: 00007FFA31CEBC20) Exception(1) tid(67c) 8A15005E ]
2024-04-01 18:03:54.851 [REPO] Failed to open available source: msstore
2024-04-01 18:03:56.122 [CLI ] No suitable installer found for manifest Microsoft.VCRedist.2015+.x64 with version 14.38.33135.0

Expected behavior

The installer verification should not fail.

Environment
This is not a winget client issue. This is an issue submitting a new version of a manifest to winget-pkgs. winget --info is not relevant.
Screenshots and Logs

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Azure pipeline validation failure referenced as #147284 and compare the dependency manifest examples linked in the issue. Reproduce validation using Microsoft.VCRedist.2015+.x64 in PackageDependencies, then trace why version 14.38.33135.0 has no suitable installer. Done means the manifest passes installer verification without removing the dependency.

Written by the indexing model from the issue text.

Assessment

Tech stack
yaml
Domain
ci-cd, release
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.