microsoft / microsoft/winget-pkgs

Support more than one manifest per PR

Open
#125 4 comments 17 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

  • #121 by @aclinick-zz — closed without merging
Area-Validation-Pipeline Issue-Feature
Dominant language
No language data
Stars
11.1k
Forks
9.7k
Avg merge
1h 32m
Merged PRs (30d)
376

Description

Description of the new feature/enhancement

Today in order to submit a PR for a manifest, I can only do 1 at a time. This is inefficient. I would like to be able to have the ability to submit multiple Manifests in one PR.

For example if I am adding a new application, I may have one or more older builds I want to submit. See Windows SDK for example:
17134, 17763, 19041, 18362

Or maybe I have multiple projects that release at one time like a suite, and each app would have its own manifest. I should be able to submit them all.

Proposed technical implementation details (optional)

I expect a submission to process each manifest individually. This should be treated like a normal PR. If the full submission does not pass, it is OK to fail the submission. Similar to code. However the BOT should communicate which manifest failed an why.

If the submission passes, then all manifests should be ingested.

The initial limit will be 8 manifests per PR. We're going to increment in binary progression.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source files, tests, or entry points are named in the issue, so begin by reviewing the repository's manifest submission and PR-bot workflow and the linked PR #121. Confirm how a PR currently processes one manifest, then define tests for up to eight manifests, per-manifest failure reporting, and all-or-nothing ingestion.

Written by the indexing model from the issue text.

Assessment

Domain
cli, release
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.