microsoft / microsoft/winget-pkgs

winget upgrades stable Mozilla.Thunderbird to beta versions (because of missing manifests for newer stable versions?)

Open
#117,949 33 comments 10 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Area-Matching Help-Wanted Issue-Bug
Dominant language
No language data
Stars
11.1k
Forks
9.7k
Avg merge
1h 32m
Merged PRs (30d)
376

Description

Brief description of your issue

Missing stable package definitions for newer sub-versions than currently listed in the package manifests causes winget to upgrade stable editions to beta versions.

example:
Winget currently tries to upgrade Mozilla Thunderbird 115.0.1, 115.1.0 and 115.1.1 (so far) to the beta 117.0b9 because there is no package manifest definition for any other version in the 115 series except for the 115.0 (115.0,0) one so winget will detect any newer stable version (installed by Mozilla's own updater) as being a beta.... and thus winget starts to install newer betas on top of existing stable editions

Steps to reproduce

see https://github.com/microsoft/winget-pkgs/issues/117895

  • install Mozilla Thunderbird 115.0 (must be 115.0), DO NOT let it to auto-update (yet)
  • check the output of winget upgrade - it should say nothing about Thunderbird
  • start Thunderbird and run the auto-updater (usually from the Help - About window), Thunderbird will auto-update itself to 115.1.1 (currently)
  • check again the output of winget upgrade - winget now identifies the installed 115.1.1 version as being part of the Thunderbird Betas, "> 117.0b4"
  • try running winget upgrade --all - winget will now install Thunderbird Beta 117 even if it was Stable 115 before
Expected behavior

even if winget is missing package manifests for newer stable versions of a software it should not install beta versions on top of the currently stable one, even if the current stable one has higher version numbers than what numbers are present in the manifests repository for whatever version winget considers as "stable"
And this especially if there is a major version change (e.g. 115->117 in the case of Thunderbird)

Actual behavior

winget upgrades stable versions to beta/testing versions.

Environment
PS C:\WINDOWS\system32> winget --info
Windows Package Manager v1.5.2201
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.19045.3393
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.20.2201.0

Winget Directories
-------------------------------------------------------------------------------------------------------------------------------
Logs                               %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir
User Settings                      %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\settings.json
Portable Links Directory (User)    %LOCALAPPDATA%\Microsoft\WinGet\Links
Portable Links Directory (Machine) C:\Program Files\WinGet\Links
Portable Package Root (User)       %LOCALAPPDATA%\Microsoft\WinGet\Packages
Portable Package Root              C:\Program Files\WinGet\Packages
Portable Package Root (x86)        C:\Program Files (x86)\WinGet\Packages

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale

Admin Setting                             State
--------------------------------------------------
LocalManifestFiles                        Disabled
BypassCertificatePinningForMicrosoftStore Disabled
InstallerHashOverride                     Disabled
LocalArchiveMalwareScanOverride           Disabled
PS C:\WINDOWS\system32>

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the package manifests and the related issue #117895, then reproduce the behavior with winget upgrade and winget upgrade --all using the Thunderbird versions described. Done means a stable 115.x installation is not offered or upgraded to Thunderbird Beta 117 merely because newer stable manifests are missing.

Written by the indexing model from the issue text.

Assessment

Domain
cli, tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.