microsoft / microsoft/winget-pkgs
Match on AppsAndFeaturesEntries.DisplayVersion if it's present
Nobody has claimed this yet.
- Dominant language
- No language data
- Stars
- 11.1k
- Forks
- 9.7k
- Avg merge
- 1h 32m
- Merged PRs (30d)
- 376
Description
The more critical thing to match is the AppsAndFeaturesEntries.DisplayVersion if it's present, then we could allow the match to comply with our policy rather than requiring that the PackageVersion matching.
If the DisplayVersion is not present, then the PackageVersion must match.
If the DisplayVersion is present, then it must match, and the PackageVersion is not required to match.
Originally posted by @denelon in https://github.com/microsoft/winget-pkgs/issues/111849#issuecomment-1631335312
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing where AppsAndFeaturesEntries.DisplayVersion and PackageVersion are evaluated in the winget matching or policy-validation workflow. Verify the three stated cases: absent DisplayVersion requires PackageVersion, while present DisplayVersion must match and PackageVersion need not. The issue does not name an implementation file or test, so locate the relevant entry point and coverage first.
Written by the indexing model from the issue text.
Assessment
- Domain
- cli
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100