microsoft / microsoft/winget-create
Support multiple manifest roots in all scenarios
Open
Nobody has claimed this yet.
Issue-Feature
- Dominant language
- C#
- Stars
- 651
- Forks
- 114
- Avg merge
- 7h 52m
- Merged PRs (30d)
- 3
Description
Description of the new feature / enhancement
Up until the creation of the fonts manifest root, WinGet-Pkgs only had a single manifests root. This root was assumed in many parts of WinGet-Create, including identity of packages not including the root.
Proposed technical implementation details
Support for full manifest root for everything requires:
- Adding manifest root type to the internal tracking identity of packages.
- Determining which root a particular manifest is in instead of assuming it is manifests.
- Updating parts where the manifest root of "manifests" is assumed or default specified.
- Tests and validating scenarios for non-Manifests root types for update, locale, etc, such as for font packages.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the internal package identity tracking and every place that assumes the "manifests" root. Add coverage for non-"manifests" roots, including update and locale scenarios such as font packages. Done means all manifest-root scenarios are supported and validated.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- cli
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 32/100