microsoft / microsoft/winget-create
PackageIdentifier - Input does not match the valid format for this field
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 651
- Forks
- 114
- Avg merge
- 7h 52m
- Merged PRs (30d)
- 3
Description
Brief description of your issue
Hey folks,
When running wingetcreate new and supplying an installer URL from a release on GitHub, then trying to accept the parsed PackageIdentifier name OR typing it in manually, I get the following error:
"Input does not match the valid format pattern for this field".
I did some searching and I'm seeing a ton of packages that have exactly this format of <author>.<package-name>, so I'm not sure what the problem is exactly.
Steps to reproduce
- Run
wingetcreate new - When prompted for InstallerUrls, enter: https://github.com/jdalley/command-palette-toggle-hdr/releases/download/v0.0.1/jdalley.ToggleHDRExtensionforCommandPalette_0.0.1.0_x64__ygjv9tpcda3x6.msix and hit enter (twice).
- Hit enter to accept suggested/parsed value of
jdalley.ToggleHDRExtensionforCommandPaletteor manually typejdalley.ToggleHDRExtensionforCommandPaletteand hit enter. - Get error
Expected behavior
Be allowed to proceed to the next step after entering a correct PackageIdentifier value.
Actual behavior
Not able to proceed to the next step after entering a correct PackageIdentifier value.
Environment
Windows Package Manager Manifest Creator v1.9.4.0
Copyright (c) Microsoft Corporation. All rights reserved.
Operating System: Microsoft Windows NT 10.0.26100.0
System Architecture: X64
Tried on both Warp terminal (Powershell 7.5.1) and Windows Terminal (Powershell 7.5.1)
Update
It turns out I didn't consider the property section length, and the following regex has enlightened me to the fact that the max length per-section is 32 characters. Shortening it does in fact fix this.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the flow with wingetcreate new and the GitHub installer URL from the report. Then inspect the referenced schemas/JSON/manifests/v1.6.0/manifest.singleton.1.6.0.json regex at line 8 and verify the per-section length constraint against the suggested PackageIdentifier. Done means confirming whether the validation is expected or whether the error needs a clearer response.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100