microsoft / microsoft/winget-create

Zip archive fails to parse on portable package update

Open
#479 9 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Issue-Bug
Dominant language
C#
Stars
651
Forks
114
Avg merge
7h 52m
Merged PRs (30d)
3

Description

Brief description of your issue

I'm trying to update the Martchus.syncthingtray package, but after the selection of the new "installer", I get "Failed to parse the package from". This is a package that's marked as a portable installer, and the zip file that gets downloaded contains the new exe

Steps to reproduce
  1. Run wingetcreate update Martchus.syncthingtray -i -v 1.4.8
  2. Enter https://github.com/Martchus/syncthingtray/releases/download/v1.4.8/syncthingtray-1.4.8-x86_64-w64-mingw32.exe.zip as new URL
  3. Select syncthingtray-1.4.8-x86_64-w64-mingw32.exe as the new installer
Expected behavior

Package parses correctly and lets me continue with updating the package

Actual behavior

Failed to parse the package from [https://github.com/Martchus/syncthingtray/releases/download/v1.4.8/syncthingtray-1.4.8-x86_64-w64-mingw32.exe.zip]

Log file:
WingetCreateLog-2023-11-20-17-14.342.txt

Environment
Windows-Paket-Manager Manifest Creator v1.5.7.0

Windows-Paket-Manager (Vorschau) v1.7.2782-preview
Copyright (c) Microsoft Corporation. Alle Rechte vorbehalten.

Windows: Windows.Desktop v10.0.22631.2715
Systemarchitektur: X64
Paket: Microsoft.DesktopAppInstaller v1.22.2782.0

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is named. Start by reproducing the failure with wingetcreate update and inspect the linked WingetCreateLog file, then trace the portable-installer package parsing entry point. Done means the specified ZIP and executable parse successfully and the package update can continue.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.