microsoft / microsoft/winget-create
Interactive update throws Duplicate installer entry found
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 651
- Forks
- 114
- Avg merge
- 7h 52m
- Merged PRs (30d)
- 3
Description
Brief description of your issue
First I want to say that I'm very new to this whole Github and winget thingy and just created my first pull requests today using wingetcreate. And I still don't fully understand everything. So please bear with me.
I picked CPU-Z as a first try as I noticed it having newer versions online. Maybe I picked a bad example.
When I wingetcreate update CPUID.CPU-Z --version 2.08 -i it will ask me 12 times for installers even though there exist only two installers - en and cn and both work for both x86 and x64 architectures.
The 2.07 YAML lists the architectures separately (same download URL) and also lists 5 different locales for the cn installer.
Running through it and trying to update it gives me
Manifest validation succeeded: False
Manifest Error: Duplicate installer entry found.
which makes sense to me.
So are the current yaml files just overly complicated or is it an issue of wingetcreate?
Steps to reproduce
In Terminal run:
wingetcreate update CPUID.CPU-Z --version '2.08' -i
and run through the interactive process providing the same URL for both architectures and use the en link for en-US and the cn link for all the **-cn languages.
https://download.cpuid.com/cpu-z/cpu-z_2.08-en.exe
https://download.cpuid.com/cpu-z/cpu-z_2.08-cn.exe
Expected behavior
As I only provide links as they are already present in the present yaml just with a newer version I would expect the manifest file to be successfully created, validated and uploaded.
Actual behavior
Manifest is saved locally though no pull request is created and an error is thrown instead:
Manifest validation succeeded: False
Manifest Error: Duplicate installer entry found.
Environment
Windows Package Manager Manifest Creator v1.5.5.0
Windows Package Manager v1.6.2771
Copyright (c) Microsoft Corporation. All rights reserved.
Windows: Windows.Desktop v10.0.22621.2428
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.21.2771.0
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing wingetcreate update CPUID.CPU-Z --version '2.08' -i with the two installer URLs and the listed locale and architecture selections. Inspect the locally saved manifest and validation output to determine why duplicate installer entries are generated; done means the manifest validates successfully and the update can create its pull request.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- yaml
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100