microsoft / microsoft/winget-create

Allow change of installer type MSI => WIX

Open
#227 0 comments 4 reactions 1 assignee View on GitHub

@ryfu-msft is already working on this.

Since Feb 11, 2022.

Issue-Feature
Dominant language
C#
Stars
651
Forks
114
Avg merge
7h 52m
Merged PRs (30d)
3

Description

Description of the new feature / enhancement

There are several packages in the community repository with the installer type currently set to MSI incorrectly. Since the addition of #217 and #220, wingetcreate can now detect when an MSI file is actually built with WIX (thanks @jedieaston!) and will match the WIX installer to the MSI entry. However, this relies on the user to update the installer type themselves, even if wingetcreate can detect it reliably.

As a user, it would be nice if installer types would automatically be updated if the detected installer type is compatible with and more specific than the installer type already defined in the manifest. As an example, InstallerType of MSI could be changed to WIX, but WIX should not be changed to MSI. Similarly, EXE could be changed to INNO, NULLSOFT, or BURN, but not the other way around;

Proposed technical implementation details

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.