microsoft / microsoft/winget-create

Submitting should check to see if there is already an open PR.

Open
#186 1 comment 5 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Issue-Feature
Dominant language
C#
Stars
651
Forks
114
Avg merge
7h 52m
Merged PRs (30d)
3

Description

Description of the new feature/enhancement

When a user tries to submit to the community repo, wingetcreate should use GitHub's Issue/PR search to see if there is already an open PR for that version, and if so, warn the user (with a link to the PR?).

Proposed technical implementation details (optional)

If you put in:path <path to folder or file> in GitHub's PR search, it will only show you PRs that are modifying files in a certain directory. For example, is:pr in:path manifests/m/Microsoft/Edge/94.0.992.38 gets me my PR from earlier today which adds version 94.0.992.38 of Microsoft Edge. This is also available via the API.

This could be used to stop duplicates of updates, since wingetcreate could check and see if someone already got to it first. Of course, a --force option should be present if someone really wants to try to open the PR anyway (perhaps they have some hot new metadata they want to add) but most of the time, we just get two of the same thing.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at wingetcreate's community-repository submission flow and review the GitHub Issues/PR search API documentation linked in the issue. Implement a check for an open PR matching the package version, warn with a link when found, and preserve a --force path for intentional duplicates.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
cli
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.