microsoft / microsoft/winget-cli
Add contstraints to simplify E2E tests
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 26.4k
- Forks
- 1.8k
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 15
Description
In #6287 it was suggested that constraints could be used for simplifying the test cases. This issue tracks that suggestion
Not for this PR, but maybe at some point we could rewrite these helpers to be constraints. Like
Assert.That(this.installDir, Repair.Exe.Completed)(but better)
Originally posted by @florelis in https://github.com/microsoft/winget-cli/pull/6287#discussion_r3575237178
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing PR #6287 and the discussion quoted in this issue to identify the E2E test helpers under consideration. Trace how those helpers are used in the existing E2E tests and determine the intended constraint interface. Done means the relevant helpers have been rewritten as constraints and the affected tests still pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- cli, testing
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100