microsoft / microsoft/winget-cli
cpprestsdk is EOL
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 26.4k
- Forks
- 1.8k
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 15
Description
Looks like there is already a fix in the official port: microsoft/vcpkg#51750
Instead of applying our own patch, we could just update the version we use.
New-PortOverlay cpprestsdk -Version 2.10.19 -PortVersion 5
While looking this up, I learned that cpprestsdk is now delisted from vcpkg (microsoft/vcpkg#52130) because the repo was archived. So maybe we'll have to figure out something else to use at some point.
Originally posted by @florelis in https://github.com/microsoft/winget-cli/pull/6301#discussion_r3484404611
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the current cpprestsdk port overlay or dependency declaration and compare it with the referenced vcpkg fix, microsoft/vcpkg#51750. Check whether version 2.10.19 with PortVersion 5 builds successfully for winget-cli; done means the dependency is updated without applying the old patch and the relevant build or tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- build-system, cli
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100