microsoft / microsoft/winget-cli
PUA: Encrypted file detections should not block legitimate packages
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 26.4k
- Forks
- 1.8k
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 15
Description
Created with GitHub Copilot assistance.
Relevant area(s)
WinGet CLI
Description of the new feature / enhancement
This is a sub-issue of #6189 for a specific class of PUA detection: encrypted files.
Some legitimate applications include encrypted components as part of their build process (e.g., auto-update clients, license enforcement modules). Detection engines like K7 flag these with generic "File is encrypted!" detections, which triggers ESRP scan blocking in the WinGet Community Repository.
Known examples:
- Trados Studio — IndigoRose TrueUpdate
UpdateClient.datis encrypted by design during the build process (PR #373424) - Malwarebytes — K7 encrypted file detection (PR #356473)
Unlike detections for remote access or adware behaviors, an "encrypted file" detection does not indicate malicious intent — it simply means a file within the installer is not readable by the scanning engine. This is a common practice for protecting proprietary update mechanisms and licensing logic.
Proposed approach
Once the parent issue (#6189) design for PUA classes and Group Policy controls is in place, "encrypted file" detections should be one of the first classes considered for an allow-path, given:
- The detection is purely structural (file is encrypted), not behavioral
- The publishers are known and have a history of legitimate submissions
- The encryption is an intentional part of their toolchain (IndigoRose TrueUpdate, etc.)
Related
- Parent: #6189
- #6107
- https://github.com/microsoft/winget-pkgs/pull/373424
- https://github.com/microsoft/winget-pkgs/pull/356473
Proposed technical implementation details
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the WinGet CLI context and parent issue #6189, whose PUA classes and Group Policy design this sub-issue depends on. Review related issue #6107 and the referenced Trados Studio and Malwarebytes package pull requests for the detection cases. Done means the resulting design identifies how encrypted-file detections can receive an allow path without treating structural encryption as malicious behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- cli, security
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100