microsoft / microsoft/winget-cli
Separate Install and Upgrade Workflows
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 26.4k
- Forks
- 1.8k
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 15
Description
Description of the new feature / enhancement
In the codebase, the workflow is InstallOrUpgrade for standard packages, Install for portable packages, and many of the strings are named for InstallOrUpdate
As the application grows more complex, the differences in functionality should be moved into their own workflows / methods. This would allow the logic to be cleaner
Proposed technical implementation details
Create separate Install() and Upgrade() methods, and have InstallOrUpgrade call the correct method
Have separate strings and behaviors based upon install or upgrade
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the InstallOrUpgrade workflow and the existing InstallOrUpdate strings, then compare the standard-package and portable-package paths. The work is done when separate Install and Upgrade methods provide distinct behavior and strings, with InstallOrUpgrade selecting the appropriate method.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- cli
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100