microsoft / microsoft/winget-cli

Better differentiation between errors and warnings

Open
#5,208 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Issue-Feature
Dominant language
C++
Stars
26.4k
Forks
1.8k
Avg merge
1d 11h
Merged PRs (30d)
15

Description

Description of the new feature / enhancement

I've seen some manifest errors being told to the author only in the form of a warning:

And some other error that don't affect the operation of winget are not raised:

Image

> winget validate --manifest <path_to_manifest>
清单验证成功。

VScode treats this as an "error".

Proposed technical implementation details

For those that would cause a Manifest-Validation-Error, we can prompt the author with a manifest validation fail.
For values that do not affect the correctness of the manifest, but are not necessary, we can prompt the author with "清单验证成功,但出现警告".

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the winget validate --manifest entry point and compare the indent, Moniker, and validation examples linked in the description. Define which manifest findings should fail validation versus produce a warning, then verify that errors are reported as failures and non-correctness issues produce a success-with-warning result.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
cli
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.