microsoft / microsoft/winget-cli
PortableCommandAlias fails when ArchiveBinariesDependOnPath
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 26.4k
- Forks
- 1.8k
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 15
Description
Brief description of your issue
When ArchiveBinariesDependOnPath is true, the value from PortableCommandAlias appears to be ignored as the exe is not renamed within the source directory.
Steps to reproduce
Create a manifest that specifies ArchiveBinariesDependOnPath: true and a PortableCommandAlias
Expected behavior
The exe would be renamed and the alias would work
Actual behavior
The exe is not renamed and the alias does not work
Environment
Windows Package Manager v1.9.25200
Copyright (c) Microsoft Corporation. All rights reserved.
Windows: Windows.Desktop v10.0.26100.2605
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.24.25200.0
Admin Setting State
--------------------------------------------------
LocalManifestFiles Enabled
BypassCertificatePinningForMicrosoftStore Disabled
InstallerHashOverride Disabled
LocalArchiveMalwareScanOverride Disabled
ProxyCommandLineOptions Disabled
DefaultProxy Disabled
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue with a manifest that sets ArchiveBinariesDependOnPath to true and specifies PortableCommandAlias. Trace the handling of both manifest fields in the C++ CLI and verify that the executable is renamed in the source directory and that the alias works.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100