microsoft / microsoft/winget-cli
Work toward u8string across the project to avoid future issues when handling extended characters
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 26.4k
- Forks
- 1.8k
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 15
Description
Brief description of your issue
This is a follow up issue filed with unicode fix PR #466
std::string is used across the project to represent strings. In some cases, it'll cause potential bugs when handling extended characters. For example, std::filesystem::path treats std:;string type as narrow case encoding.
Expected behavior
u8string is used across the project for representing strings. Or at least those deal with windows file systems are changed to use u8string.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the Unicode fix in PR #466 and tracing the project’s uses of std::string, especially where std::filesystem::path handles Windows file-system paths. Define the affected scope before changing anything; done means the relevant string representations use u8string without introducing encoding regressions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- cli, operating-systems
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100