microsoft / microsoft/winget-cli
Range request failures result in telemetry spam
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 26.4k
- Forks
- 1.8k
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 15
Description
Brief description of your issue
While the fallback to download when range requests are not supported in the MSIX streaming install case is good, it leads to telemetry spam that suggests a failure when there is not one. We should strive to not throw and catch our own exceptions as control flow.
Steps to reproduce
Attempt to install an MSIX that has a signature hash and is hosted somewhere that does not support range requests (github release for instance).
Expected behavior
The error is not logged as a failure, but as informational that we are falling back to download.
Actual behavior
The error is logged as a failure, despite the fact that we continue on and succeed to install.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the MSIX streaming install path for packages with a signature hash, focusing on the range-request fallback and its telemetry logging. Reproduce with an MSIX hosted on a source without range-request support, then verify that fallback is reported as informational and the installation still succeeds without failure telemetry.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- cli, observability
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100