microsoft / microsoft/winget-cli
Admin setting was not found logged multiple times
Open
Nobody has claimed this yet.
Issue-Bug
- Dominant language
- C++
- Stars
- 26.4k
- Forks
- 1.8k
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 15
Description
Brief description of your issue
It seems that the admin setting for default proxy is being accessed or logging multiple times
Steps to reproduce
Run any command on a fresh install
Expected behavior
Settings would only be accessed / logged once
Actual behavior
See logs below
Environment
2024-06-28 12:52:56.126 [CORE] WinGet, version [1.9.1763-preview], activity [{56EDC85A-BE3B-4CD3-980B-5FA40D345B95}]
2024-06-28 12:52:56.126 [CORE] OS: Windows.Desktop v10.0.26241.5000
2024-06-28 12:52:56.126 [CORE] Command line Args: "C:\Users\WDAGUtilityAccount\AppData\Local\Microsoft\WindowsApps\winget.exe" install Rustlang.Rust.MSVC --disable-interactivity --verbose --logs
2024-06-28 12:52:56.126 [CORE] Package: Microsoft.DesktopAppInstaller v1.24.1763.0
2024-06-28 12:52:56.126 [CORE] IsCOMCall:0; Caller: winget-cli
2024-06-28 12:52:56.138 [CLI ] WinGet invoked with arguments: 'install' 'Rustlang.Rust.MSVC' '--disable-interactivity' '--verbose' '--logs'
2024-06-28 12:52:56.138 [CLI ] Found subcommand: install
2024-06-28 12:52:56.138 [CLI ] Leaf command to execute: root:install
2024-06-28 12:52:56.140 [CORE] Setting action: Get, Type: Secure, Name: admin_settings
2024-06-28 12:52:56.140 [YAML] Detected UTF-8
2024-06-28 12:52:56.140 [YAML] Detected UTF-8
2024-06-28 12:52:56.140 [CORE] Admin setting 'DefaultProxy' was not found or did not contain the expected format
2024-06-28 12:52:56.140 [CORE] Setting action: Get, Type: Secure, Name: admin_settings
2024-06-28 12:52:56.140 [YAML] Detected UTF-8
2024-06-28 12:52:56.140 [YAML] Detected UTF-8
2024-06-28 12:52:56.140 [CORE] Admin setting 'DefaultProxy' was not found or did not contain the expected format
2024-06-28 12:52:56.141 [CORE] Setting action: Get, Type: Secure, Name: admin_settings
2024-06-28 12:52:56.141 [YAML] Detected UTF-8
2024-06-28 12:52:56.141 [YAML] Detected UTF-8
2024-06-28 12:52:56.141 [CORE] Admin setting 'DefaultProxy' was not found or did not contain the expected format
2024-06-28 12:52:56.141 [CORE] Setting action: Get, Type: Secure, Name: admin_settings
2024-06-28 12:52:56.141 [YAML] Detected UTF-8
2024-06-28 12:52:56.141 [YAML] Detected UTF-8
2024-06-28 12:52:56.141 [CORE] Admin setting 'DefaultProxy' was not found or did not contain the expected format
2024-06-28 12:52:56.141 [CORE] Setting action: Get, Type: Secure, Name: admin_settings
2024-06-28 12:52:56.141 [YAML] Detected UTF-8
2024-06-28 12:52:56.141 [YAML] Detected UTF-8
2024-06-28 12:52:56.141 [CORE] Admin setting 'DefaultProxy' was not found or did not contain the expected format
2024-06-28 12:52:56.142 [CLI ] Executing command: install
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue by running the logged winget install command on a fresh install and trace the repeated access to the DefaultProxy value in admin_settings. Confirm which command-startup path triggers the repeated reads, then verify that the missing-setting message and related setting logs appear only once.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100