Support ARP entry values of REG_EXPAND_SZ type

Open

#4,303 opened on Mar 24, 2024 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Area-Matching Issue-Feature

Dominant language: C++
Stars: 26.4k
Forks: 1.8k
Avg merge: 1d 11h
Merged PRs (30d): 15

Description

Brief description of your issue

Some installers, for example Tencent.TencentVideo, write ARP values to registry under the type of "REG_EXPAND_SZ". Currently WinGet client only supports the "REG_SZ" type and discards those of different types, including "REG_EXPAND_SZ".

Steps to reproduce

Run winget install Tencent.TencentVideo
Run winget install Tencent.TencentVideo again without --force
Run winget list

Expected behavior

After the first step, WinGet should be able to detect the ARP entry and prevent reinstalling by winget install without using --force or list the package in winget list.

Actual behavior

WinGet reinstalled the package again even without --force and the installed package didn't show up in winget list. The log shows:

2024-03-24 21:00:28.426 [REPO] Skipping qqlive because DisplayName is not a REG_SZ value

Environment

Windows Package Manager v1.7.10661
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.19045.4170
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.22.10661.0

Winget Directories
-------------------------------------------------------------------------------------------------------------------------------
Logs                               %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir
User Settings                      %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\settings.json
Portable Links Directory (User)    %LOCALAPPDATA%\Microsoft\WinGet\Links
Portable Links Directory (Machine) C:\Program Files\WinGet\Links
Portable Package Root (User)       %LOCALAPPDATA%\Microsoft\WinGet\Packages
Portable Package Root              C:\Program Files\WinGet\Packages
Portable Package Root (x86)        C:\Program Files (x86)\WinGet\Packages
Installer Downloads                %USERPROFILE%\Downloads

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale

Admin Setting                             State
--------------------------------------------------
LocalManifestFiles                        Enabled
BypassCertificatePinningForMicrosoftStore Disabled
InstallerHashOverride                     Disabled
LocalArchiveMalwareScanOverride           Disabled

Contributor guide

Open the contributing guide

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Research direction

Reproduce the issue with winget install Tencent.TencentVideo, repeat the install without --force, and run winget list. Start from the ARP discovery path that emits the DisplayName is not a REG_SZ value log, then verify REG_EXPAND_SZ values are retained. Done means the installed package is detected and is not reinstalled without --force.

Written by the indexing model from the issue text.

Assessment

Tech stack: cpp
Domain: cli, operating-systems
Issue type: Bug
Difficulty: 3/5
Estimated time: 1-2 days
Activity status: Stale
Clarity: Mostly clear
Newbie friendliness: 38/100