microsoft / microsoft/winget-cli
Enlighten WinGet to display Agreements in the defaultLocale if not in a locale file
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 26.4k
- Forks
- 1.8k
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 15
Description
Description of the new feature / enhancement
When agreements are required due to implicit tags in installer switches, the agreement title and agreement URL are required by policy for the WinGet community repository.
If an agreement field has been added to the "defaultLocale", that agreement should also be presented for users who see localized content from a locale file.
This will simplify the process of generating manifests by reducing the need to provide localized URLs or titles.
If a locale has a different localized title or URL that should be presented to the user.
Proposed technical implementation details
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how agreement fields from the defaultLocale and locale files are loaded and displayed when implicit installer-switch tags require agreements. Verify the fallback behavior for localized users, including cases with a localized title or URL; done means defaultLocale agreements appear when locale-specific values are absent, while localized values still take precedence.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- cli, localization
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100