microsoft / microsoft/winget-cli

ManifestComparator has odd behavior with local manifest

Open
#4,165 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Command-Install Issue-Bug
Dominant language
C++
Stars
26.4k
Forks
1.8k
Avg merge
1d 11h
Merged PRs (30d)
15

Description

Brief description of your issue

I am trying to test with a local manifest. The manifest does not specify a scope (Scope == Unknown). When testing with the --manifest and --scope switch, it always results in No applicable installer found; see logs for more details.

Steps to reproduce
  1. Make a clone of the winget-pkgs repo
  2. run the command winget install --manifest D:\Git\winget-pkgs\manifests\m\Microsoft\AzureCLI\2.57.0 --scope user, adapting the file path as needed
  3. Observe the failure
  4. Run winget install Microsoft.AzureCLI --version 2.57.0 --source winget --scope user
  5. Observe no failure
Expected behavior

Installer with unknown scope to be selected for local manifest install

Actual behavior

No applicable installer found; see logs for more details.

Environment
PS D:\Git\winget-pkgs> winget --info
Windows Package Manager (Preview) v1.7.3481-preview
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.19045.3930
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.22.3481.0

Winget Directories
-------------------------------------------------------------------------------------------------------------------------------
Logs                               %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir
User Settings                      %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\settings.json
Portable Links Directory (User)    %LOCALAPPDATA%\Microsoft\WinGet\Links
Portable Links Directory (Machine) C:\Program Files\WinGet\Links
Portable Package Root (User)       %LOCALAPPDATA%\Microsoft\WinGet\Packages
Portable Package Root              C:\Program Files\WinGet\Packages
Portable Package Root (x86)        C:\Program Files (x86)\WinGet\Packages
Installer Downloads                D:\Users\Trenly\Downloads

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale

Admin Setting                             State
--------------------------------------------------
LocalManifestFiles                        Enabled
BypassCertificatePinningForMicrosoftStore Disabled
InstallerHashOverride                     Disabled
LocalArchiveMalwareScanOverride           Enabled

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the ManifestComparator behavior exercised by the local --manifest install command, and reproduce the failure using the AzureCLI manifest and --scope user. Compare it with the successful package-source command; done means a local manifest whose scope is Unknown selects an applicable installer instead of reporting that none was found.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
cli, operating-systems
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.