microsoft / microsoft/winget-cli
Portable application executable is renamed despite absence of rename argument
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 26.4k
- Forks
- 1.8k
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 15
Description
Brief description of your issue
The Portable/Standalone applications documentation states:
If a command value is specified in the manifest, then the symlink filename will be renamed to match the command value. If the rename argument is provided, then both the symlink filename and the portable exe filename will be renamed to match the rename argument value.
However, the portable exe is renamed even if the rename argument is absent.
In case the behavior is intended and only the documentation is misleading, I still request changing this behavior. Renaming the exe is confusing and seems unnecessary.
Steps to reproduce
Run winget install --exact --id Microsoft.Sysinternals.ProcessExplorer --version 17.05
Note that the manifest includes:
Commands:
- process-explorer
Expected behavior
C:\Users\<username>\AppData\Local\Microsoft\WinGet\Links contains symlink process-explorer.exe.
C:\Users\<username>\AppData\Local\Microsoft\WinGet\Packages\Microsoft.Sysinternals.ProcessExplorer_Microsoft.Winget.Source_8wekyb3d8bbwe\ contains procexp64.exe.
Actual behavior
C:\Users\<username>\AppData\Local\Microsoft\WinGet\Links contains symlink process-explorer.exe.
C:\Users\<username>\AppData\Local\Microsoft\WinGet\Packages\Microsoft.Sysinternals.ProcessExplorer_Microsoft.Winget.Source_8wekyb3d8bbwe\ contains process-explorer.exe.
Environment
Windows-Paket-Manager v1.6.3482
Copyright (c) Microsoft Corporation. Alle Rechte vorbehalten.
Windows: Windows.Desktop v10.0.19045.3803
Systemarchitektur: X64
Paket: Microsoft.DesktopAppInstaller v1.21.3482.0
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue with winget install --exact --id Microsoft.Sysinternals.ProcessExplorer --version 17.05 and inspect the portable standalone application install path described in the linked documentation. Compare handling of the manifest's Commands value with the absent rename argument; done means the symlink is named process-explorer.exe while the packaged executable remains procexp64.exe.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100