microsoft / microsoft/winget-cli

Winget should use latest manifest that honours the command line arguments (--scope, for instance)

Open
#3,788 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Issue-Docs
Dominant language
C++
Stars
26.4k
Forks
1.8k
Avg merge
1d 11h
Merged PRs (30d)
15

Description

Brief description of your issue

The Microsoft.Teams package was recently updated and doesn't include a machine scope definition as Microsoft are yet to update their Machine-Wide installer or have discontinued it.

As I rely on Winget for multiple clients during Intune pre-provisioning, this presented a breaking change to our deployments where I had to hard-code what version of the app to use to return to working behaviour.

There are a few things here. While the maintainer possibly should have done a new package definition for the modern Teams client, Winget should do one of the following in this situation:

  1. Bomb out completely and not attempt to install a user-scoped app if the caller has explicitly passed --scope machine.
  2. Honour the caller's request of --scope machine and find the most current manifest that has such a scope.

Any consideration around this would be appreciated as I don't feel the current approach is best.

Steps to reproduce

From an administrative command prompt, call winget.exe install --id Microsoft.Teams --scope machine and observe how a user-scoped install occurs.

Expected behavior

A machine scoped installation occurs matching my request as the caller.

Actual behavior

User scoped installation occurs which breaks expected behavour.

Environment
Windows Package Manager v1.6.2771
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.22621.2428
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.21.2771.0

Winget Directories
-------------------------------------------------------------------------------------------------------------------------------
Logs                               %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir
User Settings                      %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\settings.json
Portable Links Directory (User)    %LOCALAPPDATA%\Microsoft\WinGet\Links
Portable Links Directory (Machine) C:\Program Files\WinGet\Links
Portable Package Root (User)       %LOCALAPPDATA%\Microsoft\WinGet\Packages
Portable Package Root              C:\Program Files\WinGet\Packages
Portable Package Root (x86)        C:\Program Files (x86)\WinGet\Packages
Installer Downloads                %USERPROFILE%\Downloads

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale

Admin Setting                             State
--------------------------------------------------
LocalManifestFiles                        Disabled
BypassCertificatePinningForMicrosoftStore Disabled
InstallerHashOverride                     Disabled
LocalArchiveMalwareScanOverride           Disabled

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing winget.exe install --id Microsoft.Teams --scope machine in the Windows Package Manager environment described. Trace how the install command applies --scope while selecting the latest manifest, then inspect the available tests around this behavior. Done means the explicit machine-scope request does not result in a user-scoped installation.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
cli, operating-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.