microsoft / microsoft/winget-cli

Updating OpenJS.NodeJS tries to install x64 version on ARM64 system

Open
#3,695 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Area-Architecture Command-Upgrade Issue-Bug
Dominant language
C++
Stars
26.4k
Forks
1.8k
Avg merge
1d 11h
Merged PRs (30d)
15

Description

Brief description of your issue

When I run the winget upgrade --all I noticed that it tried to install x64 version of the OpenJS.NodeJS package (notice the installer URL).

(11/18) Found Node.js [OpenJS.NodeJS] Version 20.7.0
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://nodejs.org/dist/v20.7.0/node-v20.7.0-x64.msi
  ██████████████████████████████  25.2 MB / 25.2 MB
Successfully verified installer hash
Starting package install...
Installer failed with exit code: 1603
Installer log is available at: C:\Users\ktos\AppData\Local\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir\WinGet-OpenJS.NodeJS.20.7.0-2023-09-27-18-44-24.457.log

(the installation failed, but nevermind)

I have checked out and NodeJS package has proper listing of arm64 installer in the yaml file, initially I was thinking someone forgot to add the installed for this architecture.

When running the winget install OpenJS.NodeJS the proper arm64 version is installed:

Found Node.js [OpenJS.NodeJS] Version 20.7.0
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://nodejs.org/dist/v20.7.0/node-v20.7.0-arm64.msi
  ██████████████████████████████  22.7 MB / 22.7 MB
Successfully verified installer hash
Starting package install...
Successfully installed

Not sure if the problem is in packaging or in the matching process somewhere.

Steps to reproduce

Run winget upgrade --all on ARM64 system with OpenJS.NodeJS installed.

Expected behavior

It should upgrade to the ARM64 version.

Actual behavior

It is trying to install x64 version.

Environment
Windows Package Manager v1.6.2631
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.22621.2361
System Architecture: Arm64
Package: Microsoft.DesktopAppInstaller v1.21.2631.0

Winget Directories
-----------------------------------------------------------------------------------------------------------------------
Logs                               %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\Diag…
User Settings                      %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\sett…
Portable Links Directory (User)    %LOCALAPPDATA%\Microsoft\WinGet\Links
Portable Links Directory (Machine) C:\Program Files\WinGet\Links
Portable Package Root (User)       %LOCALAPPDATA%\Microsoft\WinGet\Packages
Portable Package Root              C:\Program Files\WinGet\Packages
Portable Package Root (x86)        C:\Program Files (x86)\WinGet\Packages
Installer Downloads                E:\_t

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale

Admin Setting                             State
--------------------------------------------------
LocalManifestFiles                        Disabled
BypassCertificatePinningForMicrosoftStore Disabled
InstallerHashOverride                     Disabled
LocalArchiveMalwareScanOverride           Disabled

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce winget upgrade --all on an ARM64 system with OpenJS.NodeJS installed, then compare its installer selection with winget install OpenJS.NodeJS. The fix is complete when the upgrade path selects the ARM64 installer rather than the x64 MSI.

Written by the indexing model from the issue text.

Assessment

Tech stack
node.js
Domain
cli, operating-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.