microsoft / microsoft/winget-cli
Portable installers are not renamed in non-symlinked installations
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 26.4k
- Forks
- 1.8k
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 15
Description
Brief description of your issue
In a non-symlinked installation i.e. installation from a user shell in non-developer mode or when ArchiveBinariesDependOnPath: true, WinGet does not rename the portable file to PortableCommandAlias / Commands value from the manifest.
Steps to reproduce
a. #3436 (winget install FiloSottile.mkcert)
b. https://github.com/microsoft/winget-pkgs/issues/111454 (winget install Microsoft.Sysinternals.ProcessExplorer)
c. winget install Microsoft.Sysinternals.TCPView on an x64 machine since the x64 executable is named TCPView64.exe
Expected behavior
The portable file to be renamed allowing user to invoke the application through the specified command in the manifest.
Actual behavior
Portable file isn't renamed and users have to type the full exe name in order to invoke the app.
Environment
Windows Package Manager (Preview) v1.6.1573-preview
Copyright (c) Microsoft Corporation. All rights reserved.
Windows: Windows.Desktop v10.0.22621.1992
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.21.1573.0
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the non-symlinked installations in #3436, winget-pkgs#111454, and the x64 Microsoft.Sysinternals.TCPView case, including ArchiveBinariesDependOnPath: true. Trace the portable installation path responsible for placing the executable. Done means the installed file is renamed to the manifest's PortableCommandAlias or Commands value and can be invoked with that command.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 42/100