microsoft / microsoft/winget-cli

Portable executable not supported for non-exe targets

Open
#3,386 5 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Issue-Bug Portable
Dominant language
C++
Stars
26.4k
Forks
1.8k
Avg merge
1d 11h
Merged PRs (30d)
15

Description

Brief description of your issue

When trying to create a package for PlantUML, I found that the .jar file was renamed by winget-cli from plantuml.jar to plantuml.exe. This prevents packages of non-executable.

Steps to reproduce

Grab the manifest from here:

  1. https://github.com/microsoft/winget-pkgs/pull/110767
  2. run winget install --manifest F:\Files\Git\winget-pkgs-1\manifests\p\PlantUML\PlantUML\v1.2023.9\
  3. open up the directory which it was installed, for me this was C:\Users\David\AppData\Local\Microsoft\WinGet\Packages\PlantUML.PlantUML__DefaultSource.
Expected behavior

The file saved as plantuml.jar

Actual behavior

The file is renamed to plantuml.jar.exe

Environment
Windows Package Manager v1.4.11071
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.22621.1848
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.19.11071.0

Logs: %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir

User Settings: %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\settings.json

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with the PlantUML manifest from microsoft/winget-pkgs pull request 110767 and the documented winget install command. Trace how winget-cli handles the downloaded .jar for a non-exe target; done means the installed file remains plantuml.jar instead of being renamed to plantuml.jar.exe.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
cli, operating-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.