microsoft / microsoft/winget-cli

[Dependencies] - Manifest validation errors with msstore package identifier

Open
#3,271 6 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Area-Manifest Dependencies Issue-Feature msstore
Dominant language
C++
Stars
26.4k
Forks
1.8k
Avg merge
1d 11h
Merged PRs (30d)
15

Description

Brief description of your issue

Some packages may depend on programs from the Microsoft Store like Xbox Game Bar. Adding these packages as dependencies throws a manifest validation error. Ignoring the validation error, the dependencies install correctly

Steps to reproduce
Dependencies:
  PackageDependencies:
    - PackageIdentifier: 9NZKPSTSNW4P
Expected behavior

Manifest validation to succeed

Actual behavior
Manifest Error: Schema Error. [Schema validation failed.
Error context: <root>[Dependencies][PackageDependencies][0][PackageIdentifier] Description: Failed to match regex specified by 'pattern' constraint.
Error context: <root>[Dependencies][PackageDependencies][0] Description: Failed to validate against schema associated with property name 'PackageIdentifier'.
Error context: <root>[Dependencies][PackageDependencies] Description: Failed to validate item #0 in array.
Error context: <root>[Dependencies] Description: Failed to validate against schema associated with property name 'PackageDependencies'.
Error context: <root> Description: Failed to validate against schema associated with property name 'Dependencies'.
]
Environment
PS D:\Git\winget-pkgs> winget --info
Windows Package Manager (Preview) v1.5.1361-preview
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.19044.2965
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.20.1361.0

Winget Directories
-------------------------------------------------------------------------------------------------------------------------------
Logs                               %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir
User Settings                      %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\settings.json
Portable Links Directory (User)    %LOCALAPPDATA%\Microsoft\WinGet\Links
Portable Links Directory (Machine) C:\Program Files\WinGet\Links
Portable Package Root (User)       %LOCALAPPDATA%\Microsoft\WinGet\Packages
Portable Package Root              C:\Program Files\WinGet\Packages
Portable Package Root (x86)        C:\Program Files (x86)\WinGet\Packages

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale

Admin Setting                             State
--------------------------------------------------
LocalManifestFiles                        Enabled
BypassCertificatePinningForMicrosoftStore Disabled
InstallerHashOverride                     Disabled
LocalArchiveMalwareScanOverride           Enabled

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the manifest validation error with the provided PackageDependencies and Microsoft Store PackageIdentifier example. Trace the PackageIdentifier schema validation and update the relevant validation behavior so this identifier validates successfully, then verify that the dependency still installs correctly.

Written by the indexing model from the issue text.

Assessment

Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.