microsoft / microsoft/winget-cli
Support validation for multiple aliases in a single portable executable
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 26.4k
- Forks
- 1.8k
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 15
Description
Brief description of your issue
winget validate fails locally for nested portable executables with multiple aliases. Some applications expect multiple aliases from one command, which is why this is important.
Related to https://github.com/microsoft/winget-cli/issues/2523#issue-1376643992:
- This might be acceptable as long as they have different command aliases?
Perhaps this was overlooked.
Steps to reproduce
- Checkout https://github.com/microsoft/winget-pkgs/pull/94699
- Validate the
Fly-io.flyctlmanifest locally withwinget validate - Validation fails with this error:
Manifest validation failed.
Manifest Error: Duplicate relative file path found. [RelativeFilePath]
Manifest Error: Duplicate relative file path found. [RelativeFilePath]
Installation works as intended however, creating fly and flyctl aliases for flyctl.exe.
Expected behavior
Validation should succeed
Actual behavior
Validation is failing.
Environment
Windows: Windows.Desktop v10.0.22621.1105
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.19.10173.0
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the failure by validating the Fly-io.flyctl manifest from winget-pkgs pull request 94699 with winget validate. Trace manifest validation for nested portable executables and duplicate relative file paths when multiple aliases target one executable. Done means validation succeeds while installation continues to create both fly and flyctl aliases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 58/100