microsoft / microsoft/winget-cli

AppsAndFeaturesEntry not preventing upgrade

Open
#2,366 14 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Issue-Bug Portable
Dominant language
C++
Stars
26.4k
Forks
1.8k
Avg merge
1d 11h
Merged PRs (30d)
15

Description

Brief description of your issue

cc @denelon

The package Microsoft.NuGet was added as an example of a portable application. The AppsAndFeaturesEntries for the manifest are set such that the version shown on NuGet's website, 6.2.1, is the version written to the ARP table, and the full version, 6.2.1.2, is set to the Package Version. Because the version in AppsAndFeaturesEntries is an exact match for the ARP Table, and 6.2.1.2 is the latest version present, the application should not be detected as needing an upgrade. However, winget believes an upgrade is needed.

Steps to reproduce

Run winget install nuget -s winget and then winget upgrade

Expected behavior

Package which has a DisplayVersion matching the AppsAndFeaturesEntry of the latest version should not be upgraded

Actual behavior

NuGet is being detected for an upgrade
image

WinGet-2022-07-23-17-13-23.454.log

Environment
Tested with winget v1.3.1872 and v1.4.2011-preview

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with winget install nuget -s winget followed by winget upgrade, using the attached log and the AppsAndFeaturesEntries, ARP table, and Package Version details as reference. Trace upgrade detection for the Microsoft.NuGet manifest and verify that a matching DisplayVersion for the latest package no longer produces an upgrade.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
cli, operating-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.