microsoft / microsoft/winget-cli
Honor installed package locale during `winget upgrade --all`
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 26.4k
- Forks
- 1.8k
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 15
Description
When I run winget upgrade --all the Windows Package Manager should try to honor the locale for the installed package.
Ahh, if you compare the urls from the Manifest and the one you found you can see the urls we use are from a archive
https://download-installer.cdn.mozilla.net/pub/firefox/releases/
Also i think i know of your issue, you want en-US, however your computer locale is something we do not inside of the manifest.
@denelon this is tiny annoyance i've noticed, i keep installing en-US however nb-NO keeps getting installed.
Originally posted by @OfficialEsco in https://github.com/microsoft/winget-pkgs/issues/65824#issuecomment-1183355282
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing winget upgrade --all with an installed package whose locale differs from the computer locale, using the Firefox archive URLs mentioned in the issue. Trace how upgrade manifests and installed-package locale preferences are selected. Done means the upgrade honors the installed package locale, including the en-US versus nb-NO case described.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- cli, localization, operating-systems
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100