microsoft / microsoft/winget-cli
Smooth progress uses characters not available by default
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 26.4k
- Forks
- 1.8k
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 15
Description
Brief description of your issue
The smooth progress implemented in #2046 uses partial block characters to make progress bars able to show 8x as much granularity. Unfortunately, those characters are not available in Consolas, the default font used by connhost on Windows. And without fallback, connhost displays the "I don't have that glyph" character (box with a question mark inside).
Steps to reproduce
Make a progress bar appear in the dev build, while using Consolas in connhost.
Expected behavior
I would prefer that we could detect this and not use the partial block characters.
I would accept having a user setting to control it.
Actual behavior
Progress bar pushes a question mark block across until smashing it at 100%.
Environment
Not yet released winget
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the progress bar in the dev build with Consolas on Windows, then read the smooth-progress implementation from #2046. Done means Consolas no longer renders missing-glyph boxes for progress, either by avoiding partial block characters or by providing the accepted user setting.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- cli, operating-systems
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100