microsoft / microsoft/winget-cli-restsource

Released WingetSource module incorrectly named in .ZIP

Open
#109 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Issue-Bug
Dominant language
C#
Stars
317
Forks
79
PR merge metrics
No merged PRs in 30d

Description

Brief description of your issue

In the released Microsoft.Wnget.Source module is contained in a.ZIP file with an internal folder name "Winget.RestSource-WInget.PowerShell.Source. But that is NOt the name of the module and this makes it difficult to automate the download and installation.

The file downloaded is WinGet.RestSource-Winget.PowerShell.Source.zip and inside that is a folder WinGet.RestSource-Winget.PowerShell.Source. But the module name is Microsoft.Winget.Source. In PowerShell, the module name (ie in the .PSD1 and .PSM1 files must match their parent folder name to facilitate autoloading.

For any module you folks release, have the .ZIP file, and the folder inside that Zip file be consistent with the module names in the PSD1/PSM1 files.

Steps to reproduce

Download the released zip and look at the names inside the file

Expected behavior

I would like the file name to be consistent with the folder name inside the zip file and that consistent with the module.

Given the module "Microsoft.WInget.Source|" the zip file should be Microsoft.WinGet.Source.zip and contain a folder named Microsoft.WinGet

Actual behavior

see above

Environment
PSH [DB:\]: winget --info

Windows Package Manager (Preview) v1.2.3131-preview
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.22000.318
Package: Microsoft.DesktopAppInstaller v1.17.3131.0

Logs: %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
Licence Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting the released WinGet.RestSource-Winget.PowerShell.Source.zip and the module's PSD1 and PSM1 files. Compare the ZIP filename, internal folder name, and declared module name, then check how the release package is assembled. Done means the archive and its internal folder consistently match the module name and support PowerShell module autoloading.

Written by the indexing model from the issue text.

Assessment

Tech stack
powershell
Domain
release, tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.