microsoft / microsoft/win32metadata

`WinVerifyTrust()` takes `pgActionId` (Guid) by ref and not as an in parameter.

Open
#2,292 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
C++
Stars
1.5k
Forks
149
Avg merge
5d 16h
Merged PRs (30d)
4

Description

## Actual behavior

As per the title.

## Expected behavior

As the docs state its an `in` parameter and is therefore not modified, it should be projected as an `in` parameter in CsWin32.

## Repro steps

1. `NativeMethods.txt` content:
```
WinVerifyTrust
```

2. `NativeMethods.json` content (if present): N/A

3. Any of your own code that should be shared? N/A

### Context

- CsWin32 version: 0.3.269
- Win32Metadata version (if explicitly set by project): N/A
- Target Framework: net472
- `LangVersion` (if explicitly set by project): 14

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the projection using a NativeMethods.txt containing WinVerifyTrust, then inspect the metadata and CsWin32 projection path that determines how pgActionId is passed. Done means the generated signature projects pgActionId as an in parameter rather than ref, with regression coverage for this API.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
65/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.