microsoft / microsoft/win32metadata
CHILDID_SELF should be a signed integer
Open
Nobody has claimed this yet.
bug
- Dominant language
- C++
- Stars
- 1.5k
- Forks
- 149
- Avg merge
- 5d 16h
- Merged PRs (30d)
- 4
Description
`CHILDID_SELF` is currently an unsigned 32-bits integer in metadata, however the comment in the C header says that IDs can be negative. APIs like `SetWinEventHook` properly use signed integers, so comparing with CHILDID_SELF currently requires a cast.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the metadata declaration for CHILDID_SELF and compare its type with the C header comment and the signed integer usage in SetWinEventHook. Done means the generated metadata represents CHILDID_SELF as a signed integer so callers no longer need a cast when comparing it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c, cpp
- Domain
- operating-systems, tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100