microsoft / microsoft/win32metadata

How to generate anonymous enums into a enum

Open
#2,199 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
1.5k
Forks
149
Avg merge
5d 16h
Merged PRs (30d)
4

Description

In `jvmti.h`, it has:

```cpp
enum {
JVMTI_THREAD_STATE_ALIVE = 0x0001,
JVMTI_THREAD_STATE_TERMINATED = 0x0002,
JVMTI_THREAD_STATE_RUNNABLE = 0x0004,
JVMTI_THREAD_STATE_BLOCKED_ON_MONITOR_ENTER = 0x0400,
JVMTI_THREAD_STATE_WAITING = 0x0080,
JVMTI_THREAD_STATE_WAITING_INDEFINITELY = 0x0010,
JVMTI_THREAD_STATE_WAITING_WITH_TIMEOUT = 0x0020,
JVMTI_THREAD_STATE_SLEEPING = 0x0040,
JVMTI_THREAD_STATE_IN_OBJECT_WAIT = 0x0100,
JVMTI_THREAD_STATE_PARKED = 0x0200,
JVMTI_THREAD_STATE_SUSPENDED = 0x100000,
JVMTI_THREAD_STATE_INTERRUPTED = 0x200000,
JVMTI_THREAD_STATE_IN_NATIVE = 0x400000,
JVMTI_THREAD_STATE_VENDOR_1 = 0x10000000,
JVMTI_THREAD_STATE_VENDOR_2 = 0x20000000,
JVMTI_THREAD_STATE_VENDOR_3 = 0x40000000
};
```

And it also has:

```cpp
enum {
JVMTI_JAVA_LANG_THREAD_STATE_MASK = JVMTI_THREAD_STATE_TERMINATED | JVMTI_THREAD_STATE_ALIVE | JVMTI_THREAD_STATE_RUNNABLE | JVMTI_THREAD_STATE_BLOCKED_ON_MONITOR_ENTER | JVMTI_THREAD_STATE_WAITING | JVMTI_THREAD_STATE_WAITING_INDEFINITELY | JVMTI_THREAD_STATE_WAITING_WITH_TIMEOUT,
JVMTI_JAVA_LANG_THREAD_STATE_NEW = 0,
JVMTI_JAVA_LANG_THREAD_STATE_TERMINATED = JVMTI_THREAD_STATE_TERMINATED,
JVMTI_JAVA_LANG_THREAD_STATE_RUNNABLE = JVMTI_THREAD_STATE_ALIVE | JVMTI_THREAD_STATE_RUNNABLE,
JVMTI_JAVA_LANG_THREAD_STATE_BLOCKED = JVMTI_THREAD_STATE_ALIVE | JVMTI_THREAD_STATE_BLOCKED_ON_MONITOR_ENTER,
JVMTI_JAVA_LANG_THREAD_STATE_WAITING = JVMTI_THREAD_STATE_ALIVE | JVMTI_THREAD_STATE_WAITING | JVMTI_THREAD_STATE_WAITING_INDEFINITELY,
JVMTI_JAVA_LANG_THREAD_STATE_TIMED_WAITING = JVMTI_THREAD_STATE_ALIVE | JVMTI_THREAD_STATE_WAITING | JVMTI_THREAD_STATE_WAITING_WITH_TIMEOUT
};
```

Because the next enums use the first enums, the generator generated:

```cpp
public const int JVMTI_JAVA_LANG_THREAD_STATE_MASK = __AnonymousEnum_jvmti_L87_C1.JVMTI_THREAD_STATE_TERMINATED | __AnonymousEnum_jvmti_L87_C1.JVMTI_THREAD_STATE_ALIVE | __AnonymousEnum_jvmti_L87_C1.JVMTI_THREAD_STATE_RUNNABLE | __AnonymousEnum_jvmti_L87_C1.JVMTI_THREAD_STATE_BLOCKED_ON_MONITOR_ENTER | __AnonymousEnum_jvmti_L87_C1.JVMTI_THREAD_STATE_WAITING | __AnonymousEnum_jvmti_L87_C1.JVMTI_THREAD_STATE_WAITING_INDEFINITELY | __AnonymousEnum_jvmti_L87_C1.JVMTI_THREAD_STATE_WAITING_WITH_TIMEOUT;
public const int JVMTI_JAVA_LANG_THREAD_STATE_NEW = 0;
public const int JVMTI_JAVA_LANG_THREAD_STATE_TERMINATED = __AnonymousEnum_jvmti_L87_C1.JVMTI_THREAD_STATE_TERMINATED;
public const int JVMTI_JAVA_LANG_THREAD_STATE_RUNNABLE = __AnonymousEnum_jvmti_L87_C1.JVMTI_THREAD_STATE_ALIVE | __AnonymousEnum_jvmti_L87_C1.JVMTI_THREAD_STATE_RUNNABLE;
public const int JVMTI_JAVA_LANG_THREAD_STATE_BLOCKED = __AnonymousEnum_jvmti_L87_C1.JVMTI_THREAD_STATE_ALIVE | __AnonymousEnum_jvmti_L87_C1.JVMTI_THREAD_STATE_BLOCKED_ON_MONITOR_ENTER;
public const int JVMTI_JAVA_LANG_THREAD_STATE_WAITING = __AnonymousEnum_jvmti_L87_C1.JVMTI_THREAD_STATE_ALIVE | __AnonymousEnum_jvmti_L87_C1.JVMTI_THREAD_STATE_WAITING | __AnonymousEnum_jvmti_L87_C1.JVMTI_THREAD_STATE_WAITING_INDEFINITELY;
public const int JVMTI_JAVA_LANG_THREAD_STATE_TIMED_WAITING = __AnonymousEnum_jvmti_L87_C1.JVMTI_THREAD_STATE_ALIVE | __AnonymousEnum_jvmti_L87_C1.JVMTI_THREAD_STATE_WAITING | __AnonymousEnum_jvmti_L87_C1.JVMTI_THREAD_STATE_WAITING_WITH_TIMEOUT;
```

But not generated the `__AnonymousEnum_jvmti_L87_C1` type. Which cause:

```shell
error CS0103: The name '__AnonymousEnum_jvmti_L87_C1' does not exist in the current context
```

I try to use `enums.json` to let this consts into a enum, but I found that `enums.json` does not work for anonymous enums.

```json
{
"$schema": "https://github.com/microsoft/win32metadata/raw/main/generation/WinSDK/enums.schema.json",
"items": [
{
"namespace": "Java.Runtime.Tool",
"name": "JVMTI_JAVA_LANG_THREAD_STATE",
"autoPopulate": {
"filter": "JVMTI_JAVA_LANG_THREAD_STATE_",
"header": "jvmti.h"
}
}
]
}
```

Is that any way to generate anonymous enums into a enum? Besides, in `classfile_constants.h` there are all of anonymous enums, which make `Api` class full of consts.

![Image](https://github.com/user-attachments/assets/42ff5b77-6e27-43fb-aa75-ec39714ca065)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how the generator handles anonymous enums in jvmti.h and whether enums.json autoPopulate applies to them. Compare the generated references to __AnonymousEnum_jvmti_L87_C1 with the source declarations, and inspect the anonymous enums in classfile_constants.h. Done means the generated constants compile without missing anonymous-enum types and the requested enum representation is produced.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.