microsoft / microsoft/win32metadata

More issues with SHGetFileInfo

Open
#2,160 12 comments 0 reactions 0 assignees View on GitHub
missing enum usability
Dominant language
C++
Stars
1.5k
Forks
149
Avg merge
5d 16h
Merged PRs (30d)
4

Description

More issues were reported on #146 but the poster did not want to create an new issue. This issue tracks those additional enhancements.

SHGetFileInfo is missing the intptr version.

[DllImport("shell32.dll", CharSet = CharSet.Auto)]
public static extern IntPtr SHGetFileInfo(
**IntPtr** pszPath,
uint dwFileAttributes,
ref SHFILEINFO psfi,
uint cbFileInfo,
uint uFlags);
https://learn.microsoft.com/en-us/windows/win32/api/shellapi/nf-shellapi-shgetfileinfoa#shgfi_pidl-0x000000008

KnownFolderId and private const int KEY_PRESSED = 0x8000; are also missed.

https://www.pinvoke.net/default.aspx/user32.getkeystate

Contributor guide

Open the contributing guide

Research direction

Start by reviewing issue #146, the SHGetFileInfo documentation, and the linked GetKeyState reference. Confirm how the metadata represents the intptr SHGetFileInfo variant, KnownFolderId, and KEY_PRESSED; done means those missing API items are included in the generated Win32 metadata.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
operating-systems, tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.