microsoft / microsoft/win32metadata

Shell_NotifyIcon APIs marked as arch-specific due to upstream no-op packing instructions

Open
#2,126 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
1.5k
Forks
149
Avg merge
5d 16h
Merged PRs (30d)
4

Description

I'm not sure, but I believe the `Shell_NotifyIcon*` APIs are marked as architecture-specific, but they are not.

I do not think there are any layout changes to `Shell_NotifyIcon*` and the `NotifyIconData*` struct between 32-bit & 64-bit. Not sure how to verify this, though.

https://learn.microsoft.com/en-us/windows/win32/api/shellapi/nf-shellapi-shell_notifyicona
https://learn.microsoft.com/en-us/windows/win32/api/shellapi/ns-shellapi-notifyicondataa
https://learn.microsoft.com/en-us/windows/win32/api/shellapi/ns-shellapi-notifyicondataw
https://microsoft.github.io/windows-docs-rs/doc/windows/Win32/UI/Shell/struct.NOTIFYICONDATAW.html

A random online copy of the definition: https://github.com/TDahlmann/canpp/blob/7f6873c64cccc4c85e18351676fe2b5605d6f84a/canl/dm/include/WIN32/SHELLAPI.H#L378

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked Shell_NotifyIcon API and NOTIFYICONDATA definitions, then compare their 32-bit and 64-bit layouts and the generated metadata markings. Done means verifying whether the APIs and structures differ by architecture and documenting or correcting the metadata classification accordingly.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
operating-systems
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.