microsoft / microsoft/win32metadata

Lots of constants values from propkey.h are missing

Open
#2,090 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
1.5k
Forks
149
Avg merge
5d 16h
Merged PRs (30d)
4

Description

Unless I'm mistaken, some constants values defined in propkey.h are missing in metadata, for example:

```
#define CALENDAR_RESPONSESTATUS_NONE 0u
#define CALENDAR_RESPONSESTATUS_ORGANIZED 1u
#define CALENDAR_RESPONSESTATUS_TENTATIVE 2u
#define CALENDAR_RESPONSESTATUS_ACCEPTED 3u
#define CALENDAR_RESPONSESTATUS_DECLINED 4u
#define CALENDAR_RESPONSESTATUS_NOTRESPONDED 5u

#define CALENDAR_SHOWTIMEAS_FREE 0u
#define CALENDAR_SHOWTIMEAS_TENTATIVE 1u
#define CALENDAR_SHOWTIMEAS_BUSY 2u
#define CALENDAR_SHOWTIMEAS_OOF 3u

#define COMMUNICATION_DIRECTION_UNKNOWN 0u
#define COMMUNICATION_DIRECTION_INCOMING 1u
#define COMMUNICATION_DIRECTION_OUTGOING 2u

...

#define PHOTO_ORIENTATION_NORMAL 1u
#define PHOTO_ORIENTATION_FLIPHORIZONTAL 2u
#define PHOTO_ORIENTATION_ROTATE180 3u
#define PHOTO_ORIENTATION_FLIPVERTICAL 4u
#define PHOTO_ORIENTATION_TRANSPOSE 5u
#define PHOTO_ORIENTATION_ROTATE270 6u
#define PHOTO_ORIENTATION_TRANSVERSE 7u
#define PHOTO_ORIENTATION_ROTATE90 8u
...

```
However, some are defined, like these:

```
#define SYNC_STATE_NOTSETUP 0ul
#define SYNC_STATE_SYNCNOTRUN 1ul
#define SYNC_STATE_IDLE 2ul
#define SYNC_STATE_ERROR 3ul
#define SYNC_STATE_PENDING 4ul
#define SYNC_STATE_SYNCING 5ul

```

Contributor guide

Open the contributing guide

Research direction

Start by examining propkey.h and comparing its defined constants with the constants present in the generated metadata. Use the listed CALENDAR_RESPONSESTATUS, PHOTO_ORIENTATION, and SYNC_STATE values as comparison cases. Done means the missing propkey.h constants are represented consistently in metadata, with any applicable metadata validation passing.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.