microsoft / microsoft/win32metadata

`FILE_NO_COMPRESSION` and `FILE_OPEN_NO_RECALL` are defined twice

Open
#2,048 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
1.5k
Forks
149
Avg merge
5d 16h
Merged PRs (30d)
4

Description

The definitions of `FILE_NO_COMPRESSION` and `FILE_OPEN_NO_RECALL` in `Windows.Win32.System.WindowsProgramming.Apis` should be removed as these are defined as part of the `NTCREATEFILE_CREATE_OPTIONS` flags enum:

```c#
// Windows.Wdk.Storage.FileSystem.NTCREATEFILE_CREATE_OPTIONS
[Flags]
public enum NTCREATEFILE_CREATE_OPTIONS : uint
{
FILE_DIRECTORY_FILE = 1u,
FILE_NON_DIRECTORY_FILE = 0x40u,
FILE_WRITE_THROUGH = 2u,
FILE_SEQUENTIAL_ONLY = 4u,
FILE_RANDOM_ACCESS = 0x800u,
FILE_NO_INTERMEDIATE_BUFFERING = 8u,
FILE_SYNCHRONOUS_IO_ALERT = 0x10u,
FILE_SYNCHRONOUS_IO_NONALERT = 0x20u,
FILE_CREATE_TREE_CONNECTION = 0x80u,
FILE_NO_EA_KNOWLEDGE = 0x200u,
FILE_OPEN_REPARSE_POINT = 0x200000u,
FILE_DELETE_ON_CLOSE = 0x1000u,
FILE_OPEN_BY_FILE_ID = 0x2000u,
FILE_OPEN_FOR_BACKUP_INTENT = 0x4000u,
FILE_RESERVE_OPFILTER = 0x100000u,
FILE_OPEN_REQUIRING_OPLOCK = 0x10000u,
FILE_COMPLETE_IF_OPLOCKED = 0x100u,
FILE_OPEN_FOR_FREE_SPACE_QUERY = 0x800000u,
FILE_CONTAINS_EXTENDED_CREATE_INFORMATION = 0x10000000u,
FILE_NO_COMPRESSION = 0x8000u,
FILE_DISALLOW_EXCLUSIVE = 0x20000u,
FILE_SESSION_AWARE = 0x40000u,
FILE_OPEN_NO_RECALL = 0x400000u
}
```

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the generator input or entry point for Windows.Win32.System.WindowsProgramming.Apis and the NTCREATEFILE_CREATE_OPTIONS definition. Confirm where the duplicate constants are emitted, remove the redundant definitions, then run the project's generation or validation checks and verify that only the enum contains FILE_NO_COMPRESSION and FILE_OPEN_NO_RECALL.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, csharp
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.