microsoft / microsoft/win-dev-skills

Keep skills current as WinApp CLI grows and adds capability

Open
#122 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
442
Forks
33
Avg merge
2h 59m
Merged PRs (30d)
11

Description

The WinApp CLI is rapidly adding features and expanding, as a result, it'll be necessary to make sure that the skills stay up to date.

I see this lying heavily on the CLI review part process for triggering work, if necessary (it may make sense for this issue to live there, but we can move it later on). The official CLI review process should take the skills into account and ask these questions. Any official contribution or review process would take these into account:

  1. Is this a breaking change for a skill - does it change functionality in such a way that the skill may not work properly anymore? If yes, the CLI change should be tied to an associate win-dev-skills update, and cannot move forward until an associated skill update is authored.

  2. Does this change add functionality that could improve an existing skill? If yes, the CLI change should not be gated on a skill update, but an associated issue should be opened and prioritized based on perceived import of the improvement.

  3. Does this change enable a possible new skill in an existing plugin? If yes, the CLI change should not be gated on the new skill, but an associated issue should be opened and prioritized as above.

Proposal

To streamline this process, it may be nice to create an internal "skill-review" skill (turtles all the way down) that analyzes CLI updates against our skills to, most importantly, flag potential breaking changes to the skills, but also propose recommendations for how updates to the CLI could be surfaced in existing skills/new skills. These recommendations would not replace human judgement, but could keep the thought process of considering the skill automatic on every CLI review and flag potential breaking changes.

It's possible this could even be tacked on as an 8th agent sub category in the existing pr-review skill, but my instinct is to keep it separate.

In addition to this, the PR review templates should clearly state expectations for considering skills.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the CLI review process, the existing pr-review skill, and the PR review templates mentioned in the issue. Determine whether skills review should be a separate skill or an eighth pr-review category, then define how breaking changes, improvements, and new-skill opportunities are recorded. Done means the review process and templates explicitly cover skill impact and provide a repeatable way to flag follow-up work.

Written by the indexing model from the issue text.

Assessment

Domain
cli, developer-experience, tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.