folder_change_reader_t should close directory handle before closing thread pool I/O
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 3k
- Forks
- 300
- Avg merge
- 19h 12m
- Merged PRs (30d)
- 1
Description
According to CloseThreadpoolIo documentation:
You should close the associated file handle and wait for all outstanding overlapped I/O operations to complete before calling this function. You must not cause any more overlapped I/O operations to occur after calling this function.
Current implementation of folder_change_reader_state::~folder_change_reader_state does the opposite.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in include/wil/filesystem.h at folder_change_reader_state::~folder_change_reader_state and read the linked CloseThreadpoolIo documentation. Trace the folder_change_reader_t cleanup sequence and confirm how the directory handle and outstanding overlapped I/O are managed. Done means the directory handle is closed and pending I/O has completed before the thread pool I/O object is closed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- operating-systems
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 66/100