Add support for different inputs to wil::reg::set_value_binary
Open
Nobody has claimed this yet.
feature-request
- Dominant language
- C++
- Stars
- 3k
- Forks
- 300
- Avg merge
- 19h 12m
- Merged PRs (30d)
- 1
Description
I'd like to be able to pass data in formats other than std::vector<uint8_t> as input to binary registry data.
While I can write this
wil::reg::set_value_binary(HKEY_CURRENT_USER, L"Value", REG_BINARY, std::vector<uint8_t>{1, 2, 3});
This is not supported
struct MyData
{
int a;
int b;
};
wil::reg::set_value_binary(HKEY_CURRENT_USER, L"Value", REG_BINARY, std::vector<MyData>{{1, 2}, {3, 4}});
I'd also like to be able to do this.
struct POD { int a; int b; };
POD pod{};
wil::reg::set_value_binary(HKEY_CURRENT_USER, L"Value", REG_BINARY, pod);
or some support void*/size_t as the input.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating wil::reg::set_value_binary and any tests covering binary registry data. Review how its current std::vector<uint8_t> input is handled, then define and test support for vector, a POD value, or void*/size_t as described; done means the requested inputs can write REG_BINARY data correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- operating-systems
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100