microsoft / microsoft/wil

CMake configuration fails with MSBuild as the generator because of empty 'CMAKE_BUILD_TYPE'

Open
#318 9 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
3k
Forks
300
Avg merge
19h 12m
Merged PRs (30d)
1

Description

I actually wasn't able to get the repo building anymore using the instructions in the README... CMAKE_BUILD_TYPE seems to evaluate to empty string even though I call init_all / init.cmd with the right params. Perhaps something is out of sync in the readme?

Originally posted by @asklar in https://github.com/microsoft/wil/pull/317#discussion_r1161873794

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the README build instructions and init.cmd, then reproduce the configuration using the MSBuild generator while checking how CMAKE_BUILD_TYPE is passed. Done means the documented setup works with MSBuild and the configuration no longer fails because CMAKE_BUILD_TYPE is empty.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake, cpp
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.