microsoft / microsoft/wil

reserved identifier violation

Open
#21 10 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

conformance
Dominant language
C++
Stars
3k
Forks
300
Avg merge
19h 12m
Merged PRs (30d)
1

Description

I would like to point out that an identifier like “__WIL_RESOURCEdoes eventually not fit to the expected naming convention of the C++ language standard.
Would you like to adjust your selection for unique names?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at include/wil/resource.h line 19 and inspect the uses of __WIL_RESOURCE. Choose a non-reserved unique identifier, update its references, and verify that the library still builds successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
operating-systems
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.