Investigate/fix unreachable code warning suppression (C4702)
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 3k
- Forks
- 300
- Avg merge
- 19h 12m
- Merged PRs (30d)
- 1
Description
Copied from ADO task 15917057
The original bug talked about warnings coming from the tests directory and so subsequently warning suppression was added in a few places (do a search for 4702). I did a quick and dirty test of removing these suppressions and didn't encounter any warnings/errors. It's possible that the issue has either been fixed or the original issue was a compiler bug that has since been fixed. Probably just need to find a good time to test out its removal on a full build to see if any errors get spit out.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the repository for every 4702 warning suppression, especially in the tests directory, and review how each is applied. Run a full build with the suppressions removed or tested in isolation; done means confirming whether C4702 warnings or errors still occur and documenting whether the suppressions can be removed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- build-system, testing
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100