microsoft / microsoft/vscode

Customization migration - layout feedback

Open
#335,660 0 comments 0 reactions 1 assignee Claimed by @hawkticehurst View on GitHub
Dominant language
TypeScript
Stars
193k
Forks
42.4k
PR merge metrics
PR metrics pending

Description

Testing #335590

Image

* The overview page uses a "cards" layout. I think that we should use the same here as currently things are floating.
* "Skip Workspace" is rendered with a different color than "Review"

Image

* Same here, I think that we should adopt the cards to better frame the information, and help with alignment
* The title uses the term "Migrate" while the primary action uses "Convert".
* On the previous page, the count is rendered in a pill, on this page it is just a number.
* What is the meaning of the "2 selected" in the lower left hand corner? Isn't this just duplicating the information in the primary action

https://github.com/user-attachments/assets/5042f285-21b0-4a17-93d8-0e8d59943e65
* Notice how invoking the context menu, hides the selection and the `...` action

https://github.com/user-attachments/assets/1db5c7e0-8adb-4f4c-9116-eaee60e9fd19
* Going back focuses the title of the previous page which is not expected

Image
* Primary action uses "Convert 2 to Skills" while in the dialog we use "Convert to Skills"

https://github.com/user-attachments/assets/0691485f-24e1-4218-b2a2-9bf79aec746e
* This action should not be rendered as a link
* The hover affordance on both actions should have the same height

Image
* Pills seem to be rendered right next to the text, so we should do the same for "Convert to skill"

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.