microsoft / microsoft/vscode

Save confirmation dialog shown if file is closed while save is in progress

Open
#332,910 1 comment 0 reactions 1 assignee Claimed by @benibenj View on GitHub
Dominant language
TypeScript
Stars
193k
Forks
42.4k
PR merge metrics
PR metrics pending

Description

Does this issue occur when all extensions are disabled?: Yes

- VS Code Version: 1.109.5
- OS Version: Mac/Debian 13

1. Open a file somewhere where saving it is really slow (e.g. an NFS mount).
2. Edit it.
3. Press Ctrl-S, Ctrl-W really quickly.

What can sometimes happen is that it shows the "Do you want to save the changes you made to ? [Save] [Don't Save] [Cancel]" dialog, even though you already pressed Ctrl-S.

Presumably the close-file handler checks if the file has unsaved changes and if so it shows that dialog.

What it should do is also check if there is a save currently in progress, and if so just wait for that save to finish and then close the file.

It's very annoying for things like editing Git commit messages.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.